Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usage of invalid syntax python 3.7.4 #11

Closed
iTosun opened this issue Nov 28, 2019 · 4 comments · Fixed by #14
Closed

usage of invalid syntax python 3.7.4 #11

iTosun opened this issue Nov 28, 2019 · 4 comments · Fixed by #14

Comments

@iTosun
Copy link

iTosun commented Nov 28, 2019

I've been using Kubiscan on python 3.7.4, The first time i tried to use it it gave an exception, about invalid syntax. I've looked trough the file that caused this and found a argument of call_api that uses a python built-in 'async', see following link:

https://github.com/cyberark/KubiScan/blob/master/api/api_client_temp.py#L286

I've changed the argument name which resolved the problem.
@g3rzi
Copy link
Contributor

g3rzi commented Nov 28, 2019

Thank you for reporting !

This is because they changed the python API.
I will add the fix after 6.12.2019 because I have a presentation with demos and I don't want to do any change right now as everything works fine.

After I will add this change I will need to make sure that the container also works find with this change.

I will update once the fix is ready and the container doesn't have any side affects.

@disconnect3d
Copy link
Contributor

disconnect3d commented Jan 13, 2020 •
edited
Loading

Bump; would be nice to have this fixed. Send a Pr in #14 (which works for me)

disconnect3d added a commit to disconnect3d/KubiScan that referenced this issue Jan 13, 2020
@disconnect3d
Support Py version where async is keyword: fix cyberark#11
8dfb38b 
This commit changes `async=None` -> `async_=None` to support Python versions where `async` is a keyword.

Fixes cyberark#11
@disconnect3d disconnect3d mentioned this issue Jan 13, 2020
Merged
@g3rzi
Copy link
Contributor

g3rzi commented Jan 13, 2020

Thanks @disconnect3d :)
I will update you after testing it together with the container version.

@g3rzi g3rzi closed this as completed in #14 Jan 14, 2020
g3rzi added a commit that referenced this issue Jan 14, 2020
@g3rzi
Merge pull request #14 from disconnect3d/patch-1
9eda197 
Support Py version where async is keyword: fix #11
g3rzi added a commit that referenced this issue Jan 14, 2020
@g3rzi
Minor variable name change (#11)
bed6dc0 
From  `async_` to  `async_req`
@g3rzi
Copy link
Contributor

g3rzi commented Jan 14, 2020

@iTosun please check now and update if you still have problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Py version where async is keyword: fix #11 disconnect3d/KubiScan
3 participants
@disconnect3d @g3rzi @iTosun