Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing '-rp' flag. #49

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Fixing '-rp' flag. #49

merged 1 commit into from
Oct 18, 2022

Conversation

2niknatan
Copy link
Contributor

Desired Outcome

Fixing '-rp' flag.
Adding logic so it can print several Service Accounts.

Implemented Changes

Fixing the '-rp' flag so it does not print with ',' and now can print several service accounts under the same container.
Added a list to the 'Container' class.

Connected Issue/Story

Definition of Done

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@g3rzi g3rzi merged commit 319d8d4 into cyberark:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants