Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding colors to permitted pipes and adding gitignore file #2

Merged
merged 6 commits into from
May 17, 2023
Merged

Adding colors to permitted pipes and adding gitignore file #2

merged 6 commits into from
May 17, 2023

Conversation

2niknatan
Copy link

Desired Outcome

Adding colors to permitted pipes and adding gitignore

Implemented Changes

Adding colors to permitted pipes and adding gitignore file

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

g3rzi
g3rzi reviewed May 17, 2023
View reviewed changes
PipeViewer/Form1.cs
@@ -481,7 +481,7 @@ private void openFindWindow()

private void openPipeChat(string pipeName)
{
PipeChat pipeChat = new PipeChat(pipeName);
pipeChatForm pipeChat = new pipeChatForm(pipeName);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@2niknatan should be changed to PipeChatForm, also make sure to change the filename.

@g3rzi g3rzi merged commit 6ae987b into cyberark:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g3rzi g3rzi g3rzi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2niknatan @g3rzi @2nik67