Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes: env consolidation, error wrapping #197

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Bugfixes: env consolidation, error wrapping #197

merged 2 commits into from
Sep 19, 2023

Conversation

john-odonnell
Copy link
Contributor

@john-odonnell john-odonnell commented Sep 19, 2023

Desired Outcome

Fix Jenkins build:

[2023-09-19T14:26:02.124Z] TASK [Confirm error message] ***************************************************
[2023-09-19T14:26:02.124Z] fatal: [dev-test_app_ubuntu-1]: FAILED! => {
[2023-09-19T14:26:02.124Z]     "assertion": "ansible_failed_result.msg == \"'conjur_appliance_url' is undefined. 'conjur_appliance_url' is undefined\"",
[2023-09-19T14:26:02.124Z]     "changed": false,
[2023-09-19T14:26:02.124Z]     "evaluated_to": false,
[2023-09-19T14:26:02.124Z]     "msg": "Assertion failed"
[2023-09-19T14:26:02.124Z] }
[2023-09-19T14:26:02.379Z] fatal: [dev-test_app_ubuntu-2]: FAILED! => {
[2023-09-19T14:26:02.379Z]     "assertion": "ansible_failed_result.msg == \"'conjur_appliance_url' is undefined. 'conjur_appliance_url' is undefined\"",
[2023-09-19T14:26:02.379Z]     "changed": false,
[2023-09-19T14:26:02.379Z]     "evaluated_to": false,
[2023-09-19T14:26:02.379Z]     "msg": "Assertion failed"
[2023-09-19T14:26:02.379Z] }
[2023-09-19T14:26:02.379Z] fatal: [dev-test_app_centos-1]: FAILED! => {
[2023-09-19T14:26:02.379Z]     "assertion": "ansible_failed_result.msg == \"'conjur_appliance_url' is undefined. 'conjur_appliance_url' is undefined\"",
[2023-09-19T14:26:02.379Z]     "changed": false,
[2023-09-19T14:26:02.379Z]     "evaluated_to": false,
[2023-09-19T14:26:02.379Z]     "msg": "Assertion failed"
[2023-09-19T14:26:02.379Z] }
[2023-09-19T14:26:02.379Z] fatal: [dev-test_app_centos-2]: FAILED! => {
[2023-09-19T14:26:02.379Z]     "assertion": "ansible_failed_result.msg == \"'conjur_appliance_url' is undefined. 'conjur_appliance_url' is undefined\"",
[2023-09-19T14:26:02.379Z]     "changed": false,
[2023-09-19T14:26:02.379Z]     "evaluated_to": false,
[2023-09-19T14:26:02.379Z]     "msg": "Assertion failed"
[2023-09-19T14:26:02.379Z] }

Implemented Changes

  • Script dev/start.sh was not correctly parsing flags passed to it by ci/test.sh. This is fixed by manually parsing arguments instead of using getopts.
  • Role was trying to wrap Ansible errors, but the technique was outdated. This has been updated.

Connected Issue/Story

N/A

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@john-odonnell john-odonnell marked this pull request as ready for review September 19, 2023 20:50
@john-odonnell john-odonnell requested a review from a team as a code owner September 19, 2023 20:50
Copy link
Contributor

@gl-johnson gl-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@john-odonnell john-odonnell merged commit d7059c8 into main Sep 19, 2023
39 of 41 checks passed
@john-odonnell john-odonnell deleted the bugfixes branch September 19, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants