Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the batch secrets retrieval header param #98

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Conversation

telday
Copy link
Contributor

@telday telday commented Mar 16, 2021

What does this PR do?

The header parameter used to set secrets to base64 encode
on batch retrieval was changed from Accept to Accept-Encoding
in Conjur, this change reflects that.

Resolves #99

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

@telday telday requested a review from a team as a code owner March 16, 2021 15:32
Copy link
Contributor

@izgeri izgeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs a changelog message, since we changed the header type. we should be clear the issue or pull that this is associated with in Conjur, too

The header parameter used to set secrets to base64 encode
on batch retrieval was changed from Accept to Accept-Encoding
in Conjur, this change reflects that.
CHANGELOG.md Outdated Show resolved Hide resolved
@telday telday merged commit e2aa5aa into master Mar 16, 2021
@izgeri izgeri deleted the update-header-param branch March 18, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Update the header used to retrieve encoded batch secrets
2 participants