Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rh base image #324

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Update rh base image #324

merged 2 commits into from
Jun 4, 2021

Conversation

izgeri
Copy link
Contributor

@izgeri izgeri commented Jun 3, 2021 •
edited
Loading

What does this PR do?

  • Adds note to CHANGELOG about OCP 4.7 support
  • Changes base image to ubi8/ubi

The rhel7/rhel base image we've been using has a CVE and no updated image in sight.

What ticket does this PR close?

n/a

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

Manual tests

If you are preparing for a release, have you run the following manual tests to verify existing functionality continues to function as expected?

@izgeri izgeri self-assigned this Jun 3, 2021
@izgeri izgeri requested review from a team as code owners June 3, 2021 21:36
andytinkham
andytinkham approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@andytinkham andytinkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@izgeri izgeri merged commit 11c31e1 into master Jun 4, 2021
@izgeri izgeri deleted the update-rh-base-image branch June 4, 2021 15:51
@jtuttle jtuttle mentioned this pull request Jul 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andytinkham andytinkham andytinkham approved these changes

Assignees

@izgeri izgeri

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@izgeri @andytinkham