Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry toggles #527

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add telemetry toggles #527

wants to merge 1 commit into from

Conversation

john-odonnell
Copy link
Contributor

Depends on cyberark/conjur-opentelemetry-tracer#10

Desired Outcome

Currently, the Authenticator Client supports telemetry and trace reporting only if it is enabled by a dependent project. The standalone Client uses a No-op tracer in all contexts:

tracer, _ := trace.NewTracerProvider(trace.NoopProviderType, false, trace.TracerProviderConfig{})
defer tracer.Shutdown(context.Background())

The Authn Client should be able to report telemetry independently.

Implemented Changes

Use new functions from cyberark/conjur-opentelemetry-tracer#10 to setup desired tracer, and pass it to an AuthenticateWithContext implementation.

Connected Issue/Story

N/A

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

Currently, the authn client support telemetry and trace reporting only
if it is enabled by dependent project. Now the authn client can be
configured to collect telemetry with the LOG_TRACES and JAEGER_COLLECTOR_URL
environment variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant