Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ruby to v3 #306

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Update Ruby to v3 #306

merged 2 commits into from
Jan 17, 2023

Conversation

john-odonnell
Copy link
Contributor

@john-odonnell john-odonnell commented Jan 11, 2023 •
edited
Loading

Desired Outcome

Update Ruby to v3, and Bundler to a secure version.

Implemented Changes

  • Update Ruby to v3.1.x (currently resolves to 3.1.3)
  • Update Bundler to v2.3.26
  • Pin Ruby buildpack to v1.8.61 for Ruby v3.1.3 support

Connected Issue/Story

CyberArk internal issue ID: CONJSE-1571

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@john-odonnell john-odonnell force-pushed the johnodon-upgrade-ruby branch 5 times, most recently from e0e422c to 4cc4898 Compare January 11, 2023 22:14
@gl-johnson @john-odonnell
Update to Ruby 3
24ceed6 
Update Ruby to v3.1.3 to resolve CVE-2021-33621
Update Bundler to v2.3.26 to resolve CVE-2020-36327 and CVE-2021-43809
Update Rails components to v6.1
Update Rack to v2.2.5
@john-odonnell john-odonnell marked this pull request as ready for review January 11, 2023 23:33
@john-odonnell john-odonnell requested review from a team as code owners January 11, 2023 23:33
andytinkham
andytinkham requested changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@andytinkham andytinkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great, @john-odonnell! Could you update the NOTICES.txt file with the updated versions from the Gemfile as part of this PR though too, please?

doodlesbykumbi
doodlesbykumbi approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@doodlesbykumbi doodlesbykumbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

andytinkham
andytinkham approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@andytinkham andytinkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-odonnell john-odonnell merged commit 832c1ae into main Jan 17, 2023
@john-odonnell john-odonnell deleted the johnodon-upgrade-ruby branch January 17, 2023 16:18
@john-odonnell john-odonnell mentioned this pull request Mar 3, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andytinkham andytinkham andytinkham approved these changes

@doodlesbykumbi doodlesbykumbi doodlesbykumbi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@john-odonnell @andytinkham @doodlesbykumbi @gl-johnson