Rename force_read parameter to force_fetch

app/domain/authentication/authn_jwt/signing_key/fetch_jwks_uri_signing_key.rb

@@ -25,9 +25,9 @@ def initialize(
  @fetch_signing_key = fetch_signing_key
  end
 
- def call(force_read:)
+ def call(force_fetch:)
  @fetch_signing_key.call(
- refresh: force_read,
+ refresh: force_fetch,
  cache_key: jwks_uri,
  signing_key_provider: self
  )

app/domain/authentication/authn_jwt/signing_key/fetch_provider_uri_signing_key.rb

@@ -19,9 +19,9 @@ def initialize(
  @fetch_signing_key = fetch_signing_key
  end
 
- def call(force_read:)
+ def call(force_fetch:)
  @fetch_signing_key.call(
- refresh: force_read,
+ refresh: force_fetch,
  cache_key: provider_uri,
  signing_key_provider: self
  )

app/domain/authentication/authn_jwt/validate_and_decode/validate_and_decode_token.rb

@@ -41,9 +41,9 @@ def validate_token_exists
  raise Errors::Authentication::AuthnJwt::MissingToken if @jwt_token.blank?
  end
 
- def fetch_signing_key(force_read: false)
+ def fetch_signing_key(force_fetch: false)
  @jwks = signing_key_provider.call(
- force_read: force_read
+ force_fetch: force_fetch
  )
  @logger.debug(LogMessages::Authentication::AuthnJwt::SigningKeysFetchedFromCache.new)
  end
@@ -62,7 +62,7 @@ def ensure_keys_are_fresh
  LogMessages::Authentication::AuthnJwt::ValidateSigningKeysAreUpdated.new
  )
  # maybe failed due to keys rotation. Force cache to read it again
- fetch_signing_key(force_read: true)
+ fetch_signing_key(force_fetch: true)
  end
 
  def fetch_decoded_token_for_signature_only

app/domain/authentication/authn_jwt/validate_status.rb

@@ -141,7 +141,7 @@ def webservice
 
  def validate_signing_key
  signing_key_provider.call(
- force_read: false
+ force_fetch: false
  )
  @logger.debug(LogMessages::Authentication::AuthnJwt::ValidatedSigningKeyConfiguration.new)
  end

spec/app/domain/authentication/authn-jwt/signing_key/fetch_jwks_signing_key_spec.rb

@@ -93,7 +93,7 @@
  fetch_authenticator_secrets: mocked_fetch_authenticator_secrets_exist_values,
  http_lib: mocked_bad_http_response,
  create_jwks_from_http_response: mocked_create_jwks_from_http_response
- ).call(force_read: false)
+ ).call(force_fetch: false)
  end
 
  it "returns false" do
@@ -109,7 +109,7 @@
  fetch_authenticator_secrets: mocked_fetch_authenticator_secrets_exist_values,
  http_lib: mocked_bad_http_response,
  create_jwks_from_http_response: mocked_create_jwks_from_http_response
- ).call(force_read: true)
+ ).call(force_fetch: true)
  end
 
  it "returns true" do
@@ -125,7 +125,7 @@
  fetch_authenticator_secrets: mocked_fetch_authenticator_secrets_exist_values,
  http_lib: mocked_bad_http_response,
  create_jwks_from_http_response: mocked_create_jwks_from_http_response
- ).call(force_read: false)
+ ).call(force_fetch: false)
  end
 
  it "raises an error" do
@@ -142,7 +142,7 @@
  fetch_authenticator_secrets: mocked_fetch_authenticator_secrets_exist_values,
  http_lib: mocked_good_http_response,
  create_jwks_from_http_response: mocked_create_jwks_from_http_response
- ).call(force_read: false)
+ ).call(force_fetch: false)
  end
 
  it "returns jwks value" do
@@ -158,7 +158,7 @@
  fetch_authenticator_secrets: mocked_fetch_authenticator_secrets_exist_values,
  http_lib: mocked_bad_http_response,
  create_jwks_from_http_response: mocked_create_jwks_from_http_response
- ).call(force_read: false)
+ ).call(force_fetch: false)
  end
 
  it "raises an error" do

spec/app/domain/authentication/authn-jwt/signing_key/fetch_provider_uri_signing_key_spec.rb

@@ -86,7 +86,7 @@
  logger: mocked_logger,
  fetch_authenticator_secrets: mocked_fetch_authenticator_secrets_exist_values,
  discover_identity_provider: mocked_discover_identity_provider
- ).call(force_read: false)
+ ).call(force_fetch: false)
  end
 
  it "returns false" do
@@ -101,7 +101,7 @@
  logger: mocked_logger,
  fetch_authenticator_secrets: mocked_fetch_authenticator_secrets_exist_values,
  discover_identity_provider: mocked_discover_identity_provider
- ).call(force_read: true)
+ ).call(force_fetch: true)
  end
 
  it "returns true" do
@@ -118,7 +118,7 @@
  logger: mocked_logger,
  fetch_authenticator_secrets: mocked_fetch_authenticator_secrets_exist_values,
  discover_identity_provider: mocked_invalid_uri_discover_identity_provider
- ).call(force_read: false)
+ ).call(force_fetch: false)
  end
 
  it "raises an error" do
@@ -133,7 +133,7 @@
  logger: mocked_logger,
  fetch_authenticator_secrets: mocked_fetch_authenticator_secrets_exist_values,
  discover_identity_provider: mocked_discover_identity_provider
- ).call(force_read: false)
+ ).call(force_fetch: false)
  end
 
  it "does not raise error" do

spec/app/domain/authentication/authn-jwt/validate_and_decode/validate_and_decode_token_spec.rb

@@ -122,31 +122,31 @@ def valid_decoded_token(claims)
 
  allow(mocked_fetch_signing_key_provider_always_succeed).to(
  receive(:call).with(
- force_read: false
+ force_fetch: false
  ).and_return(jwks_from_1st_call)
  )
 
  allow(mocked_fetch_signing_key_provider_always_succeed).to(
  receive(:call).with(
- force_read: true
+ force_fetch: true
  ).and_return(jwks_from_2nd_call)
  )
 
  allow(mocked_fetch_signing_key_provider_failed_on_1st_time).to(
  receive(:call).with(
- force_read: false
+ force_fetch: false
  ).and_raise(fetch_signing_key_1st_time_error)
  )
 
  allow(mocked_fetch_signing_key_provider_failed_on_2nd_time).to(
  receive(:call).with(
- force_read: false
+ force_fetch: false
  ).and_return(jwks_from_2nd_call)
  )
 
  allow(mocked_fetch_signing_key_provider_failed_on_2nd_time).to(
  receive(:call).with(
- force_read: true
+ force_fetch: true
  ).and_raise(fetch_signing_key_2nd_time_error)
  )