Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set unset ENV variables to nil #1841

Closed
h-artzi opened this issue Sep 23, 2020 · 0 comments · Fixed by #1842
Closed

Set unset ENV variables to nil #1841

h-artzi opened this issue Sep 23, 2020 · 0 comments · Fixed by #1842
Assignees
@h-artzi

Comments

@h-artzi
Copy link
Contributor

h-artzi commented Sep 23, 2020 •
edited
Loading

Potential Issue:
If a user sets an ENV variables such as TRUSTED_PROXIES by running the following command
export TRUSTED_PROXIES= then the value of TRUSTED_PROXIES is not nil but ""

This can cause issues, due to the fact that we nil check some of our ENV variables to determine specific actions.

Solution:
Upon starting Conjur, set all blank ENV variables to nil.
@h-artzi h-artzi self-assigned this Sep 23, 2020
@h-artzi h-artzi mentioned this issue Sep 23, 2020
Merged
5 tasks
h-artzi added a commit that referenced this issue Sep 29, 2020
@h-artzi
update CHANGELOG #1841
c1994cf
orenbm pushed a commit that referenced this issue Oct 5, 2020
@h-artzi @orenbm
update CHANGELOG #1841
7ca8bb1
@h-artzi h-artzi linked a pull request Dec 15, 2020 that will close this issue
set all unset ENV variables to nil #1842
Merged
5 tasks
@h-artzi h-artzi closed this as completed Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h-artzi h-artzi

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set all unset ENV variables to nil cyberark/conjur
1 participant
@h-artzi