1341 - Update server status page links #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 18, 2020 21:19
- Remove the old Slack link and link to discourse instead - Update links that point to documentation, the Conjur repo, and AAM - Upgrade font-awesome to use the post-5.0 icon format
- Remove the old Slack link and link to discourse instead - Update links that point to documentation, the Conjur repo, and AAM - Upgrade font-awesome to use the post-5.0 icon format
|
It's worth noting that the status page still links to a now-defunct Conjur+TLS tutorial. It still helpfully resolves to the tutorials page, but if anyone has an idea to update the link to something more useful, I'd be glad to make that update. Even without that change, though, I think it's worth it to get this PR in and in a tagged version soon so that OSS users can benefit from an updated server status page. |
|
Code Climate has analyzed commit 73de3d5 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 88.4% (0.0% change). View more on Code Climate. |
|
Tested and it looks good! |
JakeQuilty
approved these changes
Feb 27, 2020
JakeQuilty
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ticket does this PR close?
Connected to #1341
Where should the reviewer start?
To verify the changes, you can run
./build.shand then update the quick start repo to refer to your local build instead. Then you can run through the quick start commands to get the server up and running, and visit https://localhost:8443 to see the new server status page.Or you can look at the attached screenshot.
Screenshots (if appropriate)
Has the Version and Changelog been updated?
Changelog - yes. Version - no.