Fix status page title regression #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahlee
force-pushed
the
75-status-title-regression
branch
2 times, most recently
from
edb6103
to
da9521c
Compare
When we re-wrote the status page, the title was inadvertantly changed from `Conjur Status` to just `Conjur`. This caused a failure in health checks that verified response content using the page title.
micahlee
force-pushed
the
75-status-title-regression
branch
from
da9521c
to
0b76c61
Compare
|
Code Climate has analyzed commit 0b76c61 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 85.4%. View more on Code Climate. |
jtuttle
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we re-wrote the status page, the title was inadvertantly changed from
Conjur Statusto justConjur. This caused a failure in health checks thatverified response content using the page title.
What does this PR do?
This PR corrects the status page regression.
What ticket does this PR close?
Connected to https://github.com/conjurinc/dap-support/issues/75
Checklists
Change log
Test coverage
Follow-on issues