ONYX-12932 - Rename claim mapping variable #2382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenbm
reviewed
Oct 12, 2021
orenbm
reviewed
Oct 12, 2021
orenbm
reviewed
Oct 12, 2021
app/domain/authentication/authn_jwt/input_validation/parse_mapping_claims.rb
Show resolved
Hide resolved
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
tzheleznyak
reviewed
Oct 12, 2021
sashaCher
reviewed
Oct 12, 2021
cucumber/authenticators_jwt/features/authn_jwt_token_schema.feature
Outdated
Show resolved
Hide resolved
cucumber/authenticators_jwt/features/authn_jwt_token_schema.feature
Outdated
Show resolved
Hide resolved
semyon-estrin
force-pushed
the
mapping-claims-rename
branch
from
a6b8eb1
to
0cfb87c
Compare
tzheleznyak
reviewed
Oct 12, 2021
tzheleznyak
reviewed
Oct 12, 2021
| @@ -12,6 +12,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
| [cyberark/conjur#2376](https://github.com/cyberark/conjur/pull/2376) | |||
| [cyberark/conjur#2377](https://github.com/cyberark/conjur/pull/2377) | |||
|
|
|||
| ### Changed | |||
| - Changed claims mapping variable name ('mapping-claims' => 'claim-aliases'). | |||
There was a problem hiding this comment.
@hilagross @shulifink please review this message
@semyon-estrin - This is non merge blocking comment
semyon-estrin
force-pushed
the
mapping-claims-rename
branch
from
0cfb87c
to
71ac186
Compare
|
Code Climate has analyzed commit 71ac186 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.8% (0.0% change). View more on Code Climate. |
8 tasks
semyon-estrin
added a commit
that referenced
this pull request
Oct 14, 2021
…iases ONYX-12932: Rename claim mapping variable (#2382) Rename fetch_mapping_claims class name Fix error reporting
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change is a result of field CS request. Based on #2330.
Previous variable name:
mapping-claimsNew variable name:
claim-aliasesPlease note that only user facing interface & automatic tests were changed:
Internal implementation variable names aren't changed yet.
What ticket does this PR close?
Resolves ONYX-12932
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, orAPI Changes