Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests of public-keys variable #2454

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

sashaCher
Copy link
Contributor

Desired Outcome

Test recently added public-keys variable of authn-jwt

Implemented Changes

  • Implement tests according test plan

Connected Issue/Story

ONYX-14399

Definition of Done

  • Desired outcome is achieved

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@sashaCher sashaCher requested a review from a team January 3, 2022 18:54
@sashaCher sashaCher changed the title Integration tests of public-keys variables Integration tests of public-keys variable Jan 3, 2022
@sashaCher sashaCher requested a review from eladkug January 4, 2022 18:52
@sashaCher sashaCher marked this pull request as ready for review January 4, 2022 18:52
@sashaCher sashaCher requested a review from a team as a code owner January 4, 2022 18:52
@codeclimate
Copy link

codeclimate bot commented Jan 4, 2022

Code Climate has analyzed commit 1b9b7c8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.0% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants