New ca_cert parameter in FetchJwksUriSigningKey class
#2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashaCher
force-pushed
the
authn-jwt-jwks-provider-ca-cert
branch
from
8b5a75b
to
4c33c48
Compare
tzheleznyak
reviewed
Jan 6, 2022
app/domain/authentication/authn_jwt/signing_key/fetch_jwks_uri_signing_key.rb
Outdated
Show resolved
Hide resolved
sashaCher
force-pushed
the
authn-jwt-jwks-provider-ca-cert
branch
from
4c33c48
to
2d2de16
Compare
Expected parameter type is OpenSSL::X509::Store The parameter will allow to invoke http requests to endpoints providing self-signed certificate or certificate signed by 3rd party CA
sashaCher
force-pushed
the
authn-jwt-jwks-provider-ca-cert
branch
from
2d2de16
to
b7b1757
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| jwks_keys | ||
| end | ||
|
|
||
| def jwks_keys |
There was a problem hiding this comment.
Complex method Authentication::AuthnJwt::SigningKey::FetchJwksUriSigningKey#jwks_keys (25.4)
| ) | ||
| end | ||
|
|
||
| def net_http_start(host, port, use_ssl, &block) |
There was a problem hiding this comment.
Authentication::AuthnJwt::SigningKey::FetchJwksUriSigningKey takes parameters ['host', 'port', 'use_ssl'] to 3 methods
|
Code Climate has analyzed commit b7b1757 and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 91.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
Allow FetchJwksUriSigningKey class fetch JWKS data from endpoints are providing self-signed certificate or certificate signed by 3rd party CA.
Implemented Changes
Add new
ca_certparameter to FetchJwksUriSigningKey classConnected Issue/Story
ONYX-15871
Definition of Done
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security