authn-k8s:websockets: support api endpoints with path #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtuttle
force-pushed
the
fix-authn-k8s
branch
2 times, most recently
from
bba07bb
to
c84a7ff
Compare
|
@doodlesbykumbi I've updated this PR to remove the SNI fix since it was implemented (and merged) independently by @foxefj-cyber. This PR now only includes the API path fix needed to support interfacing w/ the Rancher control plane (and possibly other k8s flavors). |
doodlesbykumbi
force-pushed
the
fix-authn-k8s
branch
4 times, most recently
from
c91f156
to
9d707e3
Compare
doodlesbykumbi
force-pushed
the
fix-authn-k8s
branch
6 times, most recently
from
2d21889
to
a591c5a
Compare
|
Code Climate has analyzed commit a591c5a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 87.9% (-1.3% change). View more on Code Climate. |
The Kubernetes API endpoint can include a path, as is the case with the Rancher API, the websocket implementation should take the URL as is instead of taking only host and port. The commit originally included support for server name indication (SNI) on the the websocket client, which enables the client to be specific about the host it is trying to reach in the first step of the TLS handshake, preventing common name mismatch errors. However, that commit was removed in favour of the more comprehensive work to support SNI at #2432.
doodlesbykumbi
force-pushed
the
fix-authn-k8s
branch
from
a591c5a
to
ed17e15
Compare
doodlesbykumbi
changed the title
|
Closed in favour of #2509 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
The Kubernetes API endpoint can include a path, as is the case with the Rancher API, the websocket implementation should take the URL as is instead of taking only host and port.
The commit originally included support for server name indication (SNI) on the the websocket client, which enables the client to be specific about the host it is trying to reach in the first step of the TLS handshake, preventing common name mismatch errors.
However, that commit was removed in favour of the more comprehensive work to support SNI at #2432.
Implemented Changes
Describe how the desired outcome above has been achieved with this PR. In
particular, consider:
Connected Issue/Story
Resolves #[relevant GitHub issue(s), e.g. 76]
CyberArk internal issue link: insert issue ID
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security