Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CVE-2022-23633; CVE-2022-23634] - Bump Rails to V6.1.4.6, Bump Puma to V5.6.2 #2492

Merged
merged 1 commit into from
Feb 13, 2022

Conversation

semyon-estrin
Copy link
Contributor

@semyon-estrin semyon-estrin commented Feb 13, 2022

Desired Outcome

conjus-oss works with Rails 6.1.4.6 and puma 5.6.2 (and all of its sub-dependencies)
This is to resolve the following Security Vulnarabilities published on 11 Feb 2022:
CVE-2022-23633
CVE-2022-23634

Implemented Changes

Updated Gemfile and Gemfile.lock

Connected Issue/Story

Definition of Done

CI is green.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@semyon-estrin semyon-estrin self-assigned this Feb 13, 2022
@semyon-estrin semyon-estrin changed the title Update to Rails 7 [CVE-2022-23633; CVE-2022-23634] - Bump Rails to V7, Bump Puma to V5.6.2 Feb 13, 2022
@semyon-estrin semyon-estrin marked this pull request as ready for review February 13, 2022 12:56
@semyon-estrin semyon-estrin requested a review from a team as a code owner February 13, 2022 12:56
@semyon-estrin semyon-estrin requested review from andytinkham and a team February 13, 2022 13:04
@semyon-estrin semyon-estrin changed the title [CVE-2022-23633; CVE-2022-23634] - Bump Rails to V7, Bump Puma to V5.6.2 [CVE-2022-23633; CVE-2022-23634] - Bump Rails to V6.1.4.6, Bump Puma to V5.6.2 Feb 13, 2022
sashaCher
sashaCher previously approved these changes Feb 13, 2022
@@ -12,6 +12,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Security
- Updated Rails to 6.1.4.4 to resolve CVE-2021-44528 (Medium, Not Vulnerable)
[cyberark/conjur#2486](https://github.com/cyberark/conjur/pull/2486)
- Updated Rails to 6.1.4.6 to resolve CVE-2022-23633
Updated Puma to 5.6.2 to resolve CVE-2022-23634
[cyberark/conjur#2492](https://github.com/cyberark/conjur/pull/2492)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing spaces

Copy link
Contributor

@sashaCher sashaCher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codeclimate
Copy link

codeclimate bot commented Feb 13, 2022

Code Climate has analyzed commit 4abaf8d and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 88.0% (-1.2% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants