Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nokogiri & rails in Gemfile.lock, and nokogiri & commonmarker in docs/Gemfile.lock #2776

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

andytinkham
Copy link
Contributor

Desired Outcome

Roll up a bunch of Dependabot PRs and get them updated before release.

Addresses #2770, #2771 , #2772, and also bumps rails.

Implemented Changes

  • Updates nokogiri and rails in the main Gemfile.lock and nokogiri & commonmarker in the docs/Gemfile.lock.
  • Cleans up the NOTICES.txt file.

…in docs/Gemfile.lock

Signed-off-by: Andy Tinkham <andy.tinkham@cyberark.com>
Copy link
Contributor

@micahlee micahlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -24,6 +24,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
allows for an HTTP proxy between Conjur and the Kubernetes API.
[cyberark/conjur#2766](https://github.com/cyberark/conjur/pull/2766)

### Security
- Updated nokogiri to 1.14.3 for CVE-2023-29469 and CVE-2023-28484 and rails to
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing spaces

@@ -24,6 +24,13 @@
allows for an HTTP proxy between Conjur and the Kubernetes API.
[cyberark/conjur#2766](https://github.com/cyberark/conjur/pull/2766)

### Security
- Updated nokogiri to 1.14.3 for CVE-2023-29469 and CVE-2023-28484 and rails to
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lists should be surrounded by blank lines

@codeclimate
Copy link

codeclimate bot commented Apr 13, 2023

Code Climate has analyzed commit 7080958 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 2

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.0% (-1.5% change).

View more on Code Climate.

@andytinkham andytinkham merged commit 912c77f into master Apr 13, 2023
@andytinkham andytinkham deleted the dependabot-fix-rollup branch April 13, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants