Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNJR-1461: Increase OIDC ttl #2800

Merged
merged 2 commits into from
May 15, 2023
Merged

CNJR-1461: Increase OIDC ttl #2800

merged 2 commits into from
May 15, 2023

Conversation

mFelgate
Copy link
Contributor

@mFelgate mFelgate commented May 12, 2023

Desired Outcome

For OIDC the token should have a 60 min lifespan, currently it is set to 8min. This pr changes the default ttl to PT60M and updates the test to confirm this as the default time.

Implemented Changes

Describe how the desired outcome above has been achieved with this PR. In
particular, consider:

  • What's changed? Why were these changes made?
    set the default ttl varibale to be set to pt60m

Connected Issue/Story

Resolves #[relevant GitHub issue(s), e.g. 76]

CyberArk internal issue ID: CNJR-1461

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@mFelgate mFelgate requested a review from a team as a code owner May 12, 2023 14:21
## [1.19.4] - 2023-05-12

### Changed
- OIDC tokens will now have a default ttl of 60 mins
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lists should be surrounded by blank lines

@codeclimate
Copy link

codeclimate bot commented May 12, 2023

Code Climate has analyzed commit 97b2217 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 1
Complexity 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 89.9% (-1.3% change).

View more on Code Climate.

@mFelgate mFelgate changed the title Increase OIDC ttl CNJR-1461: Increase OIDC ttl May 15, 2023
Copy link
Contributor

@codihuston codihuston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mFelgate mFelgate merged commit dc559e8 into master May 15, 2023
@mFelgate mFelgate deleted the increase-oidc-ttl branch May 15, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants