Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull sloislo library to conjur #2832

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

sofiadimant1
Copy link

Desired Outcome

Please describe the desired outcome for this PR. Said another way, what was
the original request that resulted in these code changes? Feel free to copy
this information from the connected issue.

Implemented Changes

Describe how the desired outcome above has been achieved with this PR. In
particular, consider:

  • What's changed? Why were these changes made?
  • How should the reviewer approach this PR, especially if manual tests are required?
  • Are there relevant screenshots you can add to the PR description?

Connected Issue/Story

Resolves #[relevant GitHub issue(s), e.g. 76]

CyberArk internal issue ID: [insert issue ID]

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@sofiadimant1 sofiadimant1 requested review from jeniaSakirko and a team as code owners June 20, 2023 10:55
@sofiadimant1 sofiadimant1 marked this pull request as draft June 20, 2023 15:01
@sofiadimant1 sofiadimant1 force-pushed the sofia/pull_slosilo_library_to_conjur branch 3 times, most recently from 6ec7927 to a6f1031 Compare June 21, 2023 05:57
@sofiadimant1 sofiadimant1 marked this pull request as ready for review June 21, 2023 07:14
@sofiadimant1 sofiadimant1 force-pushed the sofia/pull_slosilo_library_to_conjur branch 3 times, most recently from 8b0a785 to f13e741 Compare June 21, 2023 09:07
@sofiadimant1 sofiadimant1 force-pushed the sofia/pull_slosilo_library_to_conjur branch from f13e741 to 2dac589 Compare June 21, 2023 09:55
@sofiadimant1 sofiadimant1 merged commit 851c244 into conjur-cloud Jun 21, 2023
@sofiadimant1 sofiadimant1 deleted the sofia/pull_slosilo_library_to_conjur branch June 21, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants