Openssl3 base images part1 #2926
Conversation
There was a problem hiding this comment.
This is looking good! Two non-line level comments:
- Mind updating the PR description? I meant to note this on the base image PR as well.
- This should include a single CHANGELOG entry indicating that we've updated our base image to use a more modern version of Ubuntu.
Thanks!
| local envs | ||
| envs=$(docker inspect -f '{{range $index, $value := .Config.Env}}{{$value}} {{end}}' "$container") | ||
| local workDir | ||
| workDir=$(docker inspect -f '{{ .Config.WorkingDir }}' "$container") | ||
| local user | ||
| user=$(docker inspect -f '{{ .Config.User }}' "$container") | ||
| local entrypoint | ||
| entrypoint=$(docker inspect -f '[{{range $index, $value := .Config.Entrypoint }}{{if $index}},{{end}}"{{$value}}"{{end}}]' "$container") | ||
| local cmd | ||
| cmd=$(docker inspect -f '[{{range $index, $value := .Config.Cmd }}{{if $index}},{{end}}"{{$value}}"{{end}}]' "$container") | ||
| local ports | ||
| IFS=":" read -r -a ports <<< "$(docker inspect -f '{{range $port, $empty := .Config.ExposedPorts}}--change:EXPOSE {{$port}}:{{end}}' "$container")" |
There was a problem hiding this comment.
This is clever and a nice improvement to prevent duplicating configuration. Mind adding a comment at the top explaining what this is doing so it's easier to understand at-a-glance?
There was a problem hiding this comment.
Added some note.
Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM cyberark/ubuntu-ruby-fips:latest | |||
| FROM registry.tld/cyberark/ubuntu-ruby-fips:20.04-2.0.7-14 | |||
There was a problem hiding this comment.
I assume this won't be version pinned once the base image PR is merged?
There was a problem hiding this comment.
Correct, pinned just for pipeline verification.
There was a problem hiding this comment.
Removed. Build will fail until merging cyberark/conjur-base-image#122
marek-jakubowski
force-pushed
the
openssl3-base-images-part1
branch
from
6a74fd4
to
1f5feda
Compare
|
Push-forced to address review comments. @micahlee this one could be reviewed again, thanks. |
marek-jakubowski
force-pushed
the
openssl3-base-images-part1
branch
from
1f5feda
to
2b0ca6e
Compare
hdabrowski
force-pushed
the
openssl3-base-images-part1
branch
from
2b0ca6e
to
3b05d0f
Compare
marek-jakubowski
force-pushed
the
openssl3-base-images-part1
branch
2 times, most recently
from
88edbaa
to
adb87c9
Compare
micahlee
force-pushed
the
openssl3-base-images-part1
branch
from
adb87c9
to
b3c8425
Compare
marek-jakubowski
force-pushed
the
openssl3-base-images-part1
branch
from
b3c8425
to
32be785
Compare
|
Code Climate has analyzed commit 32be785 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 88.4% (0.0% change). View more on Code Climate. |
Desired Outcome
Goal is to provide some changes from #2874 to make it smaller and deliver tagging strategy earlier
Implemented Changes
Describe how the desired outcome above has been achieved with this PR. In
particular, consider:
Switched to base image new tagging
Connected Issue/Story
Resolves #[relevant GitHub issue(s), e.g. 76]
CyberArk internal issue ID: [insert issue ID]
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security