Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

Fix title rendering #171

Merged
merged 1 commit into from
Feb 7, 2021
Merged

Fix title rendering #171

merged 1 commit into from
Feb 7, 2021

Conversation

sigalsax
Copy link
Contributor

@sigalsax sigalsax commented Feb 4, 2021

What does this PR do?

Makes minor changes as per UX changes demonstrated here in the UX guide

@sigalsax sigalsax self-assigned this Feb 4, 2021
@sigalsax sigalsax requested a review from a team as a code owner February 4, 2021 12:25
@sigalsax sigalsax changed the title Update flags according to UX guidelines Fix title rendering Feb 4, 2021
tzheleznyak
tzheleznyak previously approved these changes Feb 4, 2021
conjur/cli.py Outdated
@@ -81,7 +81,7 @@ def command_epilog(example, command=None, subcommands=None):
"""
This method builds the footer for each command help screen.
"""
refer_to_help = "See more details in each subcommands help:"
refer_to_help = "See more details in each subcommand\'s help:"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the backslash is not a mistake?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it in because I thought it would error but I see now it doesnt and will only error when I use '' over ""

orenbm
orenbm previously approved these changes Feb 4, 2021
@codeclimate
Copy link

codeclimate bot commented Feb 4, 2021

Code Climate has analyzed commit 867ea56 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 91.6% (75% is the threshold).

This pull request will bring the total coverage in the repository to 68.4% (0.1% change).

View more on Code Climate.

@sigalsax sigalsax merged commit 2ba536b into master Feb 7, 2021
@sigalsax sigalsax deleted the fix-process-trigger branch February 7, 2021 05:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants