Pid2Pod Fix #45
Merged
Pid2Pod Fix #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did 2 Changes in the LookUpPod Script cause the execure of ./kubeletctl pid2pod didn't return me the desired outcome.
Change 1:
In the LookupContainerID method.
Change from FindStringSubmatch to FindAllStringSubmatch, this method captures all occurrences of the regex pattern in the text, which is crucial for environments where a process might be associated with multiple containers.
Change 2:
The script assumes there is only one container ID associated with each PID, which might not be accurate in environments where processes can appear in more than one container's.