Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs container runs and serves content successfully #1028

Closed
diverdane opened this issue Nov 26, 2019 · 0 comments
Closed

Docs container runs and serves content successfully #1028

diverdane opened this issue Nov 26, 2019 · 0 comments

Comments

@diverdane
Copy link
Contributor

Summary

Currently, if the secretless-broker docs container is failing with a version mismatch between Ruby and jekyll-sass-converter.
Reference: https://github.com/cyberark/secretless-broker/blob/master/CONTRIBUTING.md#run-in-docker

Steps to Reproduce

To reproduce the failure, run:

cd docs
docker-compose up -d

When the container is built, you will see the following error:

ERROR:  Error installing jekyll:
	There are no versions of jekyll-sass-converter (~> 2.0) compatible with your Ruby & RubyGems. Maybe try installing an older version of the gem you're looking for?
	jekyll-sass-converter requires Ruby version >= 2.4.0. The current ruby version is 2.3.7.456.

Expected Results

Container should start up, and documentation should be served on localhost:4000.

Actual Results (including error logs, if applicable)

See error message above.

Additional Information

Problem can be fixed with the following change:

diff --git a/docs/Dockerfile b/docs/Dockerfile
index b6817fd..976d7a2 100644
--- a/docs/Dockerfile
+++ b/docs/Dockerfile
@@ -1,4 +1,5 @@
-FROM ruby:2.3.7
+FROM ruby:2.4.0
+RUN gem update --system
 RUN gem install bundler jekyll
 RUN mkdir /src
 COPY ./Gemfile** /src/
diverdane pushed a commit that referenced this issue Nov 27, 2019
This change addresses a version mismatch between Ruby and
jekyll-sass-converter in the docs container. With the current
implementation, when the docs container is started with:
```
cd docs
docker-compose up -d
```
then an error is reported when the container is being built:
```
ERROR:  Error installing jekyll:
	There are no versions of jekyll-sass-converter (~> 2.0) compatible with your Ruby & RubyGems. Maybe try installing an older version of the gem you're looking for?
	jekyll-sass-converter requires Ruby version >= 2.4.0. The current ruby version is 2.3.7.456.
```

The fix is to upgrade the container to Ruby 2.4.0.

Fixes Issue #1028
@diverdane diverdane self-assigned this Nov 27, 2019
diverdane pushed a commit that referenced this issue Dec 2, 2019
This change addresses a version mismatch between Ruby and
jekyll-sass-converter in the docs container. With the current
implementation, when the docs container is started with:
```
cd docs
docker-compose up -d
```
then an error is reported when the container is being built:
```
ERROR:  Error installing jekyll:
	There are no versions of jekyll-sass-converter (~> 2.0) compatible with your Ruby & RubyGems. Maybe try installing an older version of the gem you're looking for?
	jekyll-sass-converter requires Ruby version >= 2.4.0. The current ruby version is 2.3.7.456.
```

The fix is to upgrade the container to Ruby 2.4.0.

Fixes Issue #1028
@izgeri izgeri closed this as completed Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants