Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce JDBC Tests for MSSQL #1124

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Introduce JDBC Tests for MSSQL #1124

merged 1 commit into from
Feb 5, 2020

Conversation

BradleyBoutcher
Copy link
Contributor

  • Introduced custom, lightweight, jar file for testing JDBC against our various connectors
  • Added table names to query structure, required for jdbc
  • Created integration test for jdbc integration tests following existing pattern

@BradleyBoutcher BradleyBoutcher force-pushed the petstore-int branch 3 times, most recently from 5311f14 to 8ab5e84 Compare February 4, 2020 18:48
Copy link
Contributor

@doodlesbykumbi doodlesbykumbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Left a couple small comments.

test/connector/tcp/mssql/mssql_query.go Outdated Show resolved Hide resolved
test/connector/tcp/mssql/Dockerfile Outdated Show resolved Hide resolved
@BradleyBoutcher BradleyBoutcher force-pushed the petstore-int branch 4 times, most recently from 999a1c9 to d272d8b Compare February 5, 2020 20:56
- Added table names to query, required for jdbc
- Created integration test for jdbc integration tests following existing pattern
- updated dockerfile to import custom java jar locally
- Added readme for customizing and exporting a custom jar file for JDBC
Copy link
Contributor

@sgnn7 sgnn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgnn7 sgnn7 merged commit 77438e5 into master Feb 5, 2020
@izgeri izgeri deleted the petstore-int branch May 18, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants