Consume version 0.19.0 of conjur-authn-k8s-client #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenbm
force-pushed
the
consume-authn-client-0.19.0
branch
4 times, most recently
from
afc65b2 to
fe02ac1
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
CHANGELOG.md
Outdated
| ### Added | ||
| - The `vault` provider now supports loading secrets from the KV Version 2 secret | ||
| engine. Reference a secret in Vault using the right path and a field | ||
| navigation in the Secretless configuration. | ||
| [cyberark/secretless-broker#1331](https://github.com/cyberark/secretless-broker/issues/1331) | ||
|
|
||
| ### Changed | ||
| - Update k8s authenticator client version to |
CHANGELOG.md
Outdated
| ### Changed | ||
| - Update k8s authenticator client version to | ||
| [0.19.0](https://github.com/cyberark/conjur-authn-k8s-client/blob/master/CHANGELOG.md#0190---2020-10-08), | ||
| which adds some fixes around cert injection failure (see also changes in |
CHANGELOG.md
Outdated
| ### Added | ||
| - The `vault` provider now supports loading secrets from the KV Version 2 secret | ||
| engine. Reference a secret in Vault using the right path and a field | ||
| navigation in the Secretless configuration. | ||
| [cyberark/secretless-broker#1331](https://github.com/cyberark/secretless-broker/issues/1331) | ||
|
|
||
| ### Changed | ||
| - Update k8s authenticator client version to |
There was a problem hiding this comment.
Lists should be surrounded by blank lines
This version introduces some changes that we can benefit from, especially these: - Errors in the certificate injection process on login are now printed to the client logs. [cyberark/conjur-authn-k8s-client#/170](cyberark/conjur-authn-k8s-client#170) - When authentication fails, the exponential backoff retry is correctly reset so that it will continue to attempt to authenticate until backoff is exhausted. [cyberark/conjur-authn-k8s-client#158](cyberark/conjur-authn-k8s-client#158) - Wait slightly for the client certificate file to exist after login before raising an error. [cyberark/conjur-authn-k8s-client#119](cyberark/conjur-authn-k8s-client#119)
orenbm
force-pushed
the
consume-authn-client-0.19.0
branch
from
fe02ac1 to
f141282
Compare
| ### Added | ||
| - The `vault` provider now supports loading secrets from the KV Version 2 secret | ||
| engine. Reference a secret in Vault using the right path and a field | ||
| navigation in the Secretless configuration. | ||
| [cyberark/secretless-broker#1331](https://github.com/cyberark/secretless-broker/issues/1331) | ||
|
|
||
| ### Changed | ||
| - Update k8s authenticator client version to |
There was a problem hiding this comment.
Lists should be surrounded by blank lines
|
Code Climate has analyzed commit f141282 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 50.2% (0.0% change). View more on Code Climate. |
BradleyBoutcher
pushed a commit
that referenced
this pull request
Oct 16, 2020
Consume version 0.19.0 of conjur-authn-k8s-client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version introduces some changes that we can benefit from, especially these:
cyberark/conjur-authn-k8s-client#/170
that it will continue to attempt to authenticate until backoff is exhausted.
cyberark/conjur-authn-k8s-client#158
raising an error.
cyberark/conjur-authn-k8s-client#119