-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade aws from 1.15.79 to 1.44.0 #1490
Conversation
This looks good, but it looks like 1.34.0 isn't the latest version. Is there any reason not to upgrade all the way to v1.44? |
No specific reason from a security standpoint (1.34.0 was the minimum version with the fix). @juniortaeza - go ahead and push it all the way up to latest and see if it works. I'm good with trying it and see if it works seamlessly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @szh pointed out, please try with the latest aws-sdk-go version. Additionally, please add a CHANGELOG.md entry and update NOTICES.txt. Thanks, @juniortaeza !
a5cab8f
to
315b020
Compare
@@ -12,6 +12,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
## [1.7.17] - 2023-02-09 | |||
|
|||
### Security | |||
- Updated github.com/aws/aws-sdk-go to v1.44.0 to remove security issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lists should be surrounded by blank lines
Code Climate has analyzed commit 315b020 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 70.7% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.