Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade aws from 1.15.79 to 1.44.0 #1490

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Upgrade aws from 1.15.79 to 1.44.0 #1490

merged 1 commit into from
Mar 28, 2023

Conversation

juniortaeza
Copy link
Contributor

No description provided.

@juniortaeza juniortaeza requested a review from a team as a code owner March 22, 2023 17:50
@szh
Copy link
Contributor

szh commented Mar 22, 2023

This looks good, but it looks like 1.34.0 isn't the latest version. Is there any reason not to upgrade all the way to v1.44?

@andytinkham
Copy link
Contributor

No specific reason from a security standpoint (1.34.0 was the minimum version with the fix). @juniortaeza - go ahead and push it all the way up to latest and see if it works. I'm good with trying it and see if it works seamlessly.

Copy link
Contributor

@andytinkham andytinkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @szh pointed out, please try with the latest aws-sdk-go version. Additionally, please add a CHANGELOG.md entry and update NOTICES.txt. Thanks, @juniortaeza !

@juniortaeza juniortaeza changed the title Upgrade aws from 1.15.79 to 1.34.0 Upgrade aws from 1.15.79 to 1.44.0 Mar 28, 2023
@@ -12,6 +12,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
## [1.7.17] - 2023-02-09

### Security
- Updated github.com/aws/aws-sdk-go to v1.44.0 to remove security issues
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lists should be surrounded by blank lines

@codeclimate
Copy link

codeclimate bot commented Mar 28, 2023

Code Climate has analyzed commit 315b020 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 70.7% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juniortaeza juniortaeza merged commit 9a0b0ea into main Mar 28, 2023
@juniortaeza juniortaeza deleted the aws-upgrade-branch branch March 28, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants