Enable SP to retrieve and provide German umlaut chars #500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
Enable Secrets Provider to deliver secrets with special characters/binary values.
Implemented Changes
In conjur#1989, the
/secrets
endpoint was updated to allow for the batch retrieval of secrets with binary values - adding theAccept-Encoding
header set tobase64
means Conjur will base64 encode secret values before attempting to render response JSON.We can use that functionality here to enable Secrets Provider to deliver binary/special character secrets by switching
client.RetrieveBatchSecrets()
toclient.RetrieveBatchSecretsSafe()
.Connected Issue/Story
CNJR-466
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security