Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Goreleaser to the latest version to support new Apple Silicon #56

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

rpothier
Copy link
Contributor

@rpothier rpothier commented Feb 18, 2022

Desired Outcome

Goreleaser should support the darwin arm64 images.

Implemented Changes

The current version of Goreleaser that is used does not support the new hardware.
This updated the Goreleaser version so we can add the arm64 images.

Connected Issue/Story

Is needed for #55

CyberArk internal issue link: insert issue ID

Definition of Done

  • Goreleaser is updated to latest and all the previous builds still work.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@rpothier rpothier requested a review from a team as a code owner February 18, 2022 18:36
@rpothier rpothier mentioned this pull request Feb 18, 2022
13 tasks
@rpothier rpothier self-assigned this Feb 18, 2022
Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rpothier rpothier merged commit 7270c9f into main Feb 18, 2022
@rpothier rpothier deleted the update-goreleaser branch February 18, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants