Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog #57

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Fix changelog #57

merged 1 commit into from
Mar 2, 2022

Conversation

szh
Copy link
Contributor

@szh szh commented Mar 2, 2022

CI was failing on ./bin/parse-changelog.sh after the merging of #55. This fixes it.

I'm unsure why the Jenkins pipeline didn't execute on #55 which would have alerted us to this issue before merging it. In any case it's running now.

Connected Issue/Story

Resolves N/A

Definition of Done

  • ./bin/parse-changelog.sh succeeds

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

CI was failing on `./bin/parse-changelog.sh`
@szh szh requested a review from a team as a code owner March 2, 2022 21:51
@szh szh self-assigned this Mar 2, 2022
@rpothier
Copy link
Contributor

rpothier commented Mar 2, 2022

I think the issue was due to CI doesn't run for community members. I ran CI for this commit, but I think the changelog was modified after.

Copy link
Contributor

@rpothier rpothier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szh szh merged commit 91b071b into main Mar 2, 2022
@szh szh deleted the fix-changelog branch March 2, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants