Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golang to 1.18 #60

Merged
merged 1 commit into from
May 19, 2022
Merged

Upgrade golang to 1.18 #60

merged 1 commit into from
May 19, 2022

Conversation

andytinkham
Copy link
Contributor

Signed-off-by: Andy Tinkham andy.tinkham@cyberark.com

Desired Outcome

Upgrade to Golang 1.18

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@andytinkham andytinkham requested a review from a team as a code owner May 19, 2022 17:24
Signed-off-by: Andy Tinkham <andy.tinkham@cyberark.com>
@andytinkham andytinkham force-pushed the update-golang-1.18 branch from dfc47de to 45fc135 Compare May 19, 2022 17:25
@@ -1,4 +1,4 @@
FROM golang:1.17-stretch
FROM golang:1.18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to drop the -stretch here? It's going to update us from Debian 9 (Stretch) to Debian 11 (Bullseye) which may be a larger version upgrade than you intended.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped stretch because it had more CVEs that Snyk was showing. I'm OK with the bigger update. Any concerns that the build wouldn't have caught?

@andytinkham andytinkham merged commit ee5bd8a into main May 19, 2022
@andytinkham andytinkham deleted the update-golang-1.18 branch February 23, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants