Fixes #114 adds /api to appliance url
#115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jtuttle
reviewed
Nov 30, 2022
| @@ -66,6 +66,9 @@ func providerConfig(d *schema.ResourceData) (interface{}, error) { | |||
| if appliance_url != "" { | |||
| config.ApplianceURL = appliance_url | |||
| } | |||
|
|
|||
| // Add `/api` to appliance url for Conjur Cloud support | |||
| appliance_url += "/api" | |||
There was a problem hiding this comment.
Huh, adding /api doesn't mess up a request to self-hosted?
There was a problem hiding this comment.
No, self-hosted supports with or without /api since v5 was released. I've made this change to numerous integrations to include Conjur Cloud support.
jtuttle
approved these changes
Nov 30, 2022
jtuttle
suggested changes
Nov 30, 2022
jtuttle
approved these changes
Nov 30, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
Removes the requirement to add
/apito the end of appliance urls for Conjur Cloud support.Implemented Changes
Describe how the desired outcome above has been achieved with this PR. In
particular, consider:
Added an additional line of code to append
/apito theappliance_urlvariable.Test, deploy, it will work successfully in all cases.
No.
Connected Issue/Story
Resolves #114
CyberArk internal issue ID: n/a
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security