-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing inference flag and context parameters #26
Conversation
* feature/contexts: Support contexts in getAll() # Conflicts: # src/main/java/org/cyberborean/rdfbeans/RDFBeanManager.java
* feature/contexts: Forgot to actually pass parameter to getStatements() # Conflicts: # src/main/java/org/cyberborean/rdfbeans/RDFBeanManager.java
a little bit of whitespace confusion, but other than that it looks good to me |
Looks good! It seems it addresses #20 as well? |
Im working with interfaces instead of classes. For this purpose having the inference parameter on createAll as well would be fine. Could you pls. supply the parameter for this kind of method, too? |
Are there any news about this? I would really appreciate having inferred statements included within the result set, too. Are there any plans when this feature will be available for bean interfaces? I've had a look into the code and added the required feature. Would you mind to add/change the following lines of code within class RDFBeanManager to reflect the changes within the repository as well?
I'm not allowed to push my changes so it would be great if you could perform these changes! Thanks a lot, Thorben |
The change you have suggested only affects identification of resources for a specific RDF type. I think we have to consider inferred triples also on getters execution: so it needs a bit more work. I'm also thinking if it would be better to have this flag as a RDFBeanManager property, rather than to pass it to each individual method. |
|
Are there any news about this topic? I'm currently working with a slightly modified version of RDFBeans that contains my three suggested changes. That's fine for my requirements but I do understand that the issue should be solved in a more generic way. Do you have an idea when the issued could be solved? For our team it is a bit difficult to work with a modified version that isn't archived officially within Maven. It would be great if this issue would be fixed. Perhaps you can announce a timeline? |
Cf. #25
Although eventually, I am not using rdfbeans for loading/storing data atm. others might find these additional parameters useful.