Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #33

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Update README.md #33

merged 2 commits into from
Nov 6, 2023

Conversation

harunkurtdev
Copy link
Contributor

Hello,
I got an error while copying the readme file and
I fixed the readme for the reader, it runs on the copied readme file.

docker build . --file Dockerfile_webots_cloud --tag cyberbotics/webots.cloud:latest [--build-arg BASE_IMAGE=cyberbotics/webots:latest] [--build-arg WEBOTS_VERSION=R2023a]
ERROR: "docker buildx build" requires exactly 1 argument.
See 'docker buildx build --help'.

Usage:  docker buildx build [OPTIONS] PATH | URL | -

@harunkurtdev
Update README.md
f61e323 
docker buildx build error fixed.
@omichel omichel added the documentation Improvements or additions to documentation label Nov 3, 2023
omichel
omichel approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@omichel omichel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution!
However, because these values are the default values, there is no need to pass them on the command line. So, I believe the instructions could be simplified (see my commit). Do you agree?

@omichel omichel changed the base branch from master to docker_buildx_build November 6, 2023 09:54
@omichel omichel merged commit 8bfe59c into cyberbotics:docker_buildx_build Nov 6, 2023
@omichel omichel mentioned this pull request Nov 6, 2023
Merged
omichel added a commit that referenced this pull request Nov 6, 2023
@omichel @harunkurtdev
Update README.md (#33) (#36)
1127611 
* Update README.md

docker buildx build error fixed.

* Simplified

---------

Co-authored-by: harunkurtme <50794236+harunkurtme@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omichel omichel omichel approved these changes

Assignees

@harunkurtdev harunkurtdev

Labels
documentation Improvements or additions to documentation test suite
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harunkurtdev @omichel