fix custom key routing

[ahmedbally]

support laravel 8 custom key routing
https://laravel.com/docs/8.x/routing#customizing-the-default-key-name

[antonkomarev]

Thank you for the contribution @ahmedbally! It will be great to cover this in tests to not break this feature in the future: https://github.com/cybercog/laravel-optimus/blob/master/tests/Traits/OptimusEncodedRouteKeyTest.php

[ahmedbally]

I hope you find it well
I tried my best 👍
if you could re-run tests it will give you success

[antonkomarev]

Your code is OK, it's scrutenizer config issue. Thank you for your efforts. I will test it and release then.

[antonkomarev]

I've tested it, this way we have a breaking change. For example when we have our encoded key stored in public_id property. Then we can not bypass it anymore.

This would not work anymore:

Route::get('/posts/{public_id:encodedId}', function (Post $post) {
    return $post;
});

[antonkomarev]

But since originally we haven't used $field parameter - it is not a case. Nobody can use it this way.

[antonkomarev]

Merged it, and will do small tweak in #31

public function resolveRouteBinding($value, $field = null)
{
    if ($field === null) {
        $field = $this->getRouteKeyName();
    }

    if (is_string($value) && ctype_digit($value)) {
        $value = (int) $value;
    }

    if (is_int($value) && $field === $this->getRouteKeyName()) {
        $value = $this->getOptimus()->decode($value);
    }

    return $this->where($field, $value)->first();
}

It will allow us to explicitly use route key too:

Route::get('/posts/{id:encodedId}', function (Post $post) {
    return $post;
});

[ahmedbally]

this get into my mind when i was taking a shower 😂 😂 😂

[ahmedbally]

thank you for your tweaks

[antonkomarev]

Laravel Optimus v3.7.0 has been released! @ahmedbally you are in contributors list now 🥇

[antonkomarev]

If you have a twitter - I could mention you in the release post.

[ahmedbally]

I am very happy to be in contributors list
that's my twitter
https://twitter.com/ahmedbally
thanks