Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

without multipart unable to upload files #40

Merged
merged 1 commit into from
Jun 30, 2018

Conversation

dmkdev
Copy link

@dmkdev dmkdev commented Jun 28, 2018

No description provided.

@antonkomarev
Copy link
Member

Thank you for the PR, @dmkdev!

Could you provide test for this use case? Or at least describe how it works without your PR and how it will work with it.

@dmkdev
Copy link
Author

dmkdev commented Jun 29, 2018

Hi, @a-komarev ! My use case:

$mutipart = [[
            'name' => 'files',
            'filename' => 'filename',
            'contents' => fopen('/path/to/file', 'r'),
        ]];
        
$response = $this->youtrack->post('/issue/' . $issueId . '/attachment', [], [
           'multipart' => $mutipart
]);

WIthout PR unable to set options 'multipart'

@antonkomarev
Copy link
Member

I'm merging it, but its not ready for release. Will make some more changes later.

@antonkomarev
Copy link
Member

antonkomarev commented Jun 30, 2018

@dmkdev I've added you to contributors list, but cannot place your avatar, because default GitHub avatars are not sizing (rendering 420x420 by default) and it breaks markup.

Release 6.1.0 published. Thank you for the feature contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants