Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading the files for a cross-platform package #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aeldably
Copy link
Collaborator

No description provided.

@aeldably aeldably requested a review from cyberjunk October 17, 2024 11:18
Copy link
Owner

@cyberjunk cyberjunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ahmed-Eldably

Code changes are fine in Matlab 2020a on Windows.
But it complains about missing liblsl:

Could not locate the file "lsl.dll" on your computer. Attempting to download...
See https://github.com/labstreaminglayer/liblsl-Matlab/#troubleshooting for further troubleshooting tips
See https://github.com/labstreaminglayer/liblsl-Matlab/#troubleshooting for further troubleshooting tips
See https://github.com/labstreaminglayer/liblsl-Matlab/#troubleshooting for further troubleshooting tips
Error using lsl_loadlib (line 47)
Invalid default value for property 'lib' in class 'lsl':
Error loading the liblsl library: Undefined function 'lsl_loadlib_' for input arguments of type 'char'. Make sure liblsl-Matlab/bin is added to path and
try running build_mex.m

Error in main (line 29)
mylsl            = lsl();

It downloads the lsl.dll but I have to additionally put all the .mexw64 back into the liblsl-Matlab/bin folder. I tried running build_mex.m but that didn't do anything.

Can we please continue to provide a precompiled liblsl inside the repo? Preferrably for Windows (X64) and macOS (UNIVERSAL2) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants