Skip to content
This repository has been archived by the owner on Dec 17, 2024. It is now read-only.

Metric table_bloat_approx_summary_sql fails with Divide by Zero #491

Closed
dtmdl opened this issue Jun 10, 2022 · 7 comments
Closed

Metric table_bloat_approx_summary_sql fails with Divide by Zero #491

dtmdl opened this issue Jun 10, 2022 · 7 comments

Comments

@dtmdl
Copy link
Contributor

dtmdl commented Jun 10, 2022

Similar to #464 (get_table_bloat_approx_sql), the table_bloat_approx_summary_sql fails with a divide by zero error in some circumstances. I applied the same fix to the postgres 12 metric_su.sql, and it appears to work correctly.

@github-actions
Copy link

📅 This issue has been automatically marked as stale because lack of recent activity. It will be closed if no further activity occurs.
♻️ If you think there is new information allowing us to address the issue, please reopen it and provide us with updated details.
🤝 Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 10, 2022
@dtmdl
Copy link
Contributor Author

dtmdl commented Aug 10, 2022

Still applicable.

@pashagolub
Copy link
Collaborator

What version is affected?

Thanks in advance

@pashagolub pashagolub self-assigned this Aug 10, 2022
@pashagolub pashagolub moved this to Todo in pgwatch2 Aug 10, 2022
@github-actions github-actions bot removed the stale label Aug 11, 2022
@dtmdl
Copy link
Contributor Author

dtmdl commented Aug 15, 2022

I encountered the problem using:

pgwatch2 1.9.0
postgresql 14.4

Not sure if it's limited to those versions, or just a problem with newly-created (empty) databases.

@github-actions
Copy link

📅 This issue has been automatically marked as stale because lack of recent activity. It will be closed if no further activity occurs.
♻️ If you think there is new information allowing us to address the issue, please reopen it and provide us with updated details.
🤝 Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 15, 2022
@dtmdl
Copy link
Contributor Author

dtmdl commented Oct 18, 2022

Still applicable.

@github-actions github-actions bot removed the stale label Oct 19, 2022
@pashagolub
Copy link
Collaborator

Sorry for delay with answer. Would you please open the pull request with a fix?

Thanks in advance!

pashagolub added a commit that referenced this issue Dec 1, 2022
[-] fix `table_bloat_approx_summary_sql` when `tblpages = 0`, closes #491
Repository owner moved this from Todo to Done in pgwatch2 Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants