This repository has been archived by the owner on Dec 17, 2024. It is now read-only.
Gatherer: improve variable expansion in YAML configs #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand only if the value starts with a "$" - can cause invalid passwords otherwise if a random generated password contains a $ in the middle. This still leaves a hole for cases where random generated password has $ on the 1st positiona, but still better than currently
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand only if the value starts with a "$" - can cause invalid passwords
otherwise if a random generated password contains a $ in the middle.
This still leaves a hole for cases where random generated password has $
on the 1st positiona, but still better than currently