Skip to content
This repository has been archived by the owner on Dec 17, 2024. It is now read-only.

[+] use predefined Grafana dashboards uid, fixes #474 #480

Merged
merged 3 commits into from
May 17, 2022
Merged

[+] use predefined Grafana dashboards uid, fixes #474 #480

merged 3 commits into from
May 17, 2022

Conversation

pashagolub
Copy link
Collaborator

[+] add uid to v8 dashboards
[-] fix import_all.sh and set_up_grafana_dashboards*.sh
[-] fix delete_all_old_pw2_dashes.sh

@pashagolub
[+] use predefined Grafana dashboards uid, fixed #474
d95a43d 
[+] add `uid` to v8 dashboards
[-] fix `import_all.sh` and `set_up_grafana_dashboards*.sh`
[-] fix `delete_all_old_pw2_dashes.sh`
@pashagolub pashagolub self-assigned this May 17, 2022
@yanchenko-igor
Copy link
Contributor

looks good, but maybe we should fix influxdb and prometheus dashboards as well?

@pashagolub
Copy link
Collaborator Author

Influxdb fixed by set_up_grafana_dashboards.sh. I just didn't update JSONs since it doesn't matter here.
Prometheus needs a separate issue and branch, I believe. The provisioning of its dashboards made somehow different

@yanchenko-igor
Copy link
Contributor

Influxdb fixed by set_up_grafana_dashboards.sh. I just didn't update JSONs since it doesn't matter here. Prometheus needs a separate issue and branch, I believe. The provisioning of its dashboards made somehow different

Well, if we deploy pgwatch2 using helm chart, we don't run the script, we are using the json files.

@pashagolub
Copy link
Collaborator Author

Oh, I didn't know that! Good point!
@yanchenko-igor, would you please point me to how we do provisioning with helm charts?

@yanchenko-igor
Copy link
Contributor

Oh, I didn't know that! Good point! @yanchenko-igor, would you please point me to how we do provisioning with helm charts?

It's just adding the json files to Configmap https://github.com/cybertec-postgresql/pgwatch2/blob/helmchart/helm-chart/templates/grafana-dashboards.yaml

@pashagolub
Copy link
Collaborator Author

Thanks! Will add uid for influx jsons as well

@yanchenko-igor
Copy link
Contributor

What about linkUrl in other json files?

@pashagolub
Copy link
Collaborator Author

Crap! :-(

@pashagolub pashagolub merged commit aef7141 into master May 17, 2022
@pashagolub pashagolub deleted the 474_fix_dashboard_permlinks branch May 17, 2022 23:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yanchenko-igor yanchenko-igor yanchenko-igor approved these changes

@kmoppel-cognite kmoppel-cognite Awaiting requested review from kmoppel-cognite

Assignees

@pashagolub pashagolub

Labels
bug dashboards deployment grafana
Projects
No open projects
pgwatch2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pashagolub @yanchenko-igor