This repository has been archived by the owner on Dec 17, 2024. It is now read-only.
[-] fix helm chart affinity, toleration, nodeSelector and extraVolumes for daemon container
#631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmpetit
changed the title
|
@yanchenko-igor would you please review this pull request? Thanks in advance! |
pashagolub
changed the title
affinity, toleration, nodeSelector and extraVolumes for daemon container
pashagolub
approved these changes
May 31, 2023
pashagolub
approved these changes
Jul 6, 2023
|
Thank you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for the container pgwatch2-daemon, some properties are missing in the deployment.yaml file:
fix #630 : as used in the webui container, add some affinity toleration & nodeSelector properties
feat #632: i prefer to use the env var PW_CONFIG so i need to add a json file including the target to monitor. A way to do it is to add some extras volume mounts parameter.