-
Notifications
You must be signed in to change notification settings - Fork 231
[+] allow .pgpass
lookup for web UI
#646
[+] allow .pgpass
lookup for web UI
#646
Conversation
.pgpass
lookup for web UI
Seems to be a breaking change. @kmoppel any ideas on this? /cc @kmoppel-cognite |
The issue is that when you do not provide password, then currently it will set the default value which is not empty and when you provide some password, then it will not do any .pgpass lookup. Lookup works fine for metric DB, but not for config DB. This could break docker container if it assumes this value is coming from default value set here: Lines 367 to 368 in 26cb0be
In that case maybe it would be good to set it for docker container with environment variables. Generally default value for passwords is assumed to be empty string. |
I think its OK to have it as is, it won't break the default Docker containers because there's trust auth for 127.0.0.1 - but please also change ENV_VARIABLES.md to reflect new default @krisavi Otherwise a nice thing to have! |
OK, I will add commit updating ENV_VARIABLES.md |
Prettier VSCode extension removed duplicate empty rows in ENV_VARIABLES.md as well. |
Thanks for your help! |
Currently it does not support pgpass for web config db. This will fix it. If password is provided, then it will be used instead.