This repository has been archived by the owner on Dec 17, 2024. It is now read-only.
[-] fix warning about yaml.load() is deprecated, closes #738
#739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pashagolub
changed the title
yaml.load() is deprecated, closes #738
|
Thanks for your help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for deprecated use of the yaml.load function. Apparently yaml.load carries some security concerns with how it de-serializes data from the yaml file, (arbitrary python code could be executed if embedded in the yaml file). As a result the library maintainers want users to be more explicit about what loader they are using to load the yaml.
The current usage of yaml.load in pgwatch2 is equivalent to the yaml.full_load function used in this PR. A safer choice might be the yaml.safe_load function but I would be concerned about regression issues.
Let me know if this change makes sense to you or if you want to drop down to using the safe_load function. Also let me know if you would like me to include some unit tests to prevent regressions/deprecation issues going forward.