-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #184 abao should understand security schemes #185
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull need improve.
- We need api for hooks something like
test.isSecuredBy('securitySchema') => boolean
test.isTraitOfSecuritySchema('securitySchema') => boolean
- Please add examples for hooks
- We need change logic for option headers
Agree with Nikita on his points. Additionally, how do we prove this works in the real world? |
Seems like this is more controversial than I expected it would be. The PR satisfies my company's needs. Unfortunately, this is a side project for me, and one I can't really justify spending much more time on. Right now, when I see comments like "how do we prove this works in the real world" I'm inclined to think that adjusting this PR to the feedback will take more time than I can allocate to it. At this point, I'm inclined to close the PR. If someone thinks I'm misunderstanding what they're saying, please let me know. |
Sorry. Thought it was a valid question. If we add it, we should be able to prove it works, no? |
There are test(s?) included with the pull request which show that we generate tests for the appropriate endpoints. To me, that's the proof that it works. I'm not sure what you mean by "works in the real world". |
This fixes issue #184. Please let me know if you have any issues with it or any additional testing information you'd like to have.