Posting: allow app to add/delete permlinks #893 #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's possible to setup coping of csv to docker, where executable copied, but this test is not strictly required. it used only for local testing of whole permlinks dump. so decided to simply skip it in buildkite to reduce dependices
This was referenced Aug 29, 2019
s-medvedev
reviewed
Sep 4, 2019
| require_auth(_self); | ||
| uint64_t parent_pk = 0; | ||
| if (parent.author) { | ||
| eosio::check(parent.permlink.size() > 0, "Parent permlink must not be empty"); |
There was a problem hiding this comment.
In case of addpermlinks action this message doesn't give information about failed permlink. It's will be good to add some information to understand which on which permlink fails.
afalaleev
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.