Skip to content

Commit

Permalink
Merge pull request #128 from erikgb/deprecate-v1
Browse files Browse the repository at this point in the history
chore: deprecate v1 and v2alpha1 SubNamespace API
  • Loading branch information
zoetrope authored Jul 5, 2024
2 parents 8ccf25a + c351e25 commit 4b22f41
Show file tree
Hide file tree
Showing 5 changed files with 34 additions and 10 deletions.
3 changes: 3 additions & 0 deletions api/accurate/v1/subnamespace_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,10 @@ type SubNamespaceSpec struct {
}

//+kubebuilder:object:root=true
//+kubebuilder:deprecatedversion:warning="The v1 version of SubNamespace has been deprecated and will be removed in a future release of the API. Please upgrade."

// SubNamespace is the Schema for the subnamespaces API
// Deprecated: This type will be removed in one of the next releases.
type SubNamespace struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`
Expand All @@ -46,6 +48,7 @@ type SubNamespace struct {
//+kubebuilder:object:root=true

// SubNamespaceList contains a list of SubNamespace
// Deprecated: This type will be removed in one of the next releases.
type SubNamespaceList struct {
metav1.TypeMeta `json:",inline"`
metav1.ListMeta `json:"metadata,omitempty"`
Expand Down
3 changes: 3 additions & 0 deletions api/accurate/v2alpha1/subnamespace_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,12 @@ type SubNamespaceSpec struct {
}

//+kubebuilder:object:root=true
//+kubebuilder:deprecatedversion:warning="The v2alpha1 version of SubNamespace has been deprecated and will be removed in a future release of the API. Please upgrade."
//+kubebuilder:subresource:status
//+genclient

// SubNamespace is the Schema for the subnamespaces API
// Deprecated: This type will be removed in one of the next releases.
type SubNamespace struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`
Expand All @@ -52,6 +54,7 @@ type SubNamespace struct {
//+kubebuilder:object:root=true

// SubNamespaceList contains a list of SubNamespace
// Deprecated: This type will be removed in one of the next releases.
type SubNamespaceList struct {
metav1.TypeMeta `json:",inline"`
metav1.ListMeta `json:"metadata,omitempty"`
Expand Down
16 changes: 12 additions & 4 deletions charts/accurate/templates/generated/crds.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 14 additions & 4 deletions config/crd/bases/accurate.cybozu.com_subnamespaces.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/crd_subnamespace.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 4b22f41

Please sign in to comment.