generated from cybozu-go/neco-template
-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: opt-in allowing cascade delete of namespaces
- Loading branch information
Showing
12 changed files
with
293 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| package hooks_allow_cascade_delete | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| . "github.com/onsi/ginkgo/v2" | ||
| . "github.com/onsi/gomega" | ||
|
|
||
| corev1 "k8s.io/api/core/v1" | ||
| "k8s.io/apimachinery/pkg/api/errors" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
|
|
||
| accuratev2 "github.com/cybozu-go/accurate/api/accurate/v2" | ||
| "github.com/cybozu-go/accurate/pkg/constants" | ||
| ) | ||
|
|
||
| var _ = Describe("Webhook allow cascade delete", func() { | ||
| var ( | ||
| ctx context.Context | ||
| root *corev1.Namespace | ||
| ) | ||
|
|
||
| BeforeEach(func() { | ||
| ctx = context.Background() | ||
|
|
||
| root = &corev1.Namespace{} | ||
| root.GenerateName = "cascade-root-" | ||
| root.Labels = map[string]string{constants.LabelType: constants.NSTypeRoot} | ||
| Expect(k8sClient.Create(ctx, root)).To(Succeed()) | ||
| }) | ||
|
|
||
| Context("Namespace", func() { | ||
| It("should ALLOW deleting a root with children", func() { | ||
| sub := &corev1.Namespace{} | ||
| sub.GenerateName = "cascade-sub-" | ||
| sub.Labels = map[string]string{constants.LabelParent: root.Name} | ||
| Expect(k8sClient.Create(ctx, sub)).To(Succeed()) | ||
|
|
||
| Expect(k8sClient.Delete(ctx, root)).To(Succeed()) | ||
| }) | ||
|
|
||
| It("should ALLOW deleting a sub-namespace with children", func() { | ||
| sub := &corev1.Namespace{} | ||
| sub.GenerateName = "cascade-sub-" | ||
| sub.Labels = map[string]string{constants.LabelParent: root.Name} | ||
| Expect(k8sClient.Create(ctx, sub)).To(Succeed()) | ||
|
|
||
| subSub := &corev1.Namespace{} | ||
| subSub.GenerateName = "cascade-sub-sub-" | ||
| subSub.Labels = map[string]string{constants.LabelParent: sub.Name} | ||
| Expect(k8sClient.Create(ctx, subSub)).To(Succeed()) | ||
|
|
||
| Expect(k8sClient.Delete(ctx, sub)).To(Succeed()) | ||
| }) | ||
|
|
||
| It("should DENY deleting a template with children", func() { | ||
| tmpl := &corev1.Namespace{} | ||
| tmpl.GenerateName = "cascade-tmpl-" | ||
| tmpl.Labels = map[string]string{constants.LabelType: constants.NSTypeTemplate} | ||
| Expect(k8sClient.Create(ctx, tmpl)).To(Succeed()) | ||
|
|
||
| root.Labels[constants.LabelTemplate] = tmpl.Name | ||
| Expect(k8sClient.Update(ctx, root)).To(Succeed()) | ||
|
|
||
| err := k8sClient.Delete(ctx, tmpl) | ||
| Expect(err).To(HaveOccurred()) | ||
| Expect(errors.ReasonForError(err)).Should(Equal(metav1.StatusReasonForbidden)) | ||
| }) | ||
| }) | ||
|
|
||
| Context("SubNamespace", func() { | ||
| It("should ALLOW deletion with child namespaces", func() { | ||
| sub := &accuratev2.SubNamespace{} | ||
| sub.Namespace = root.Name | ||
| sub.GenerateName = "cascade-sub-" | ||
| Expect(k8sClient.Create(ctx, sub)).To(Succeed()) | ||
| // Create sub-namespace since no controllers present in this test setup | ||
| subNS := &corev1.Namespace{} | ||
| subNS.Name = sub.Name | ||
| subNS.Labels = map[string]string{constants.LabelParent: root.Name} | ||
| Expect(k8sClient.Create(ctx, subNS)).To(Succeed()) | ||
|
|
||
| ns := &corev1.Namespace{} | ||
| ns.GenerateName = "cascade-sub-sub-" | ||
| ns.Labels = map[string]string{constants.LabelParent: subNS.Name} | ||
| Expect(k8sClient.Create(ctx, ns)).To(Succeed()) | ||
|
|
||
| Expect(k8sClient.Delete(ctx, sub)).To(Succeed()) | ||
| }) | ||
| }) | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,160 @@ | ||
| package hooks_allow_cascade_delete | ||
|
|
||
| import ( | ||
| "context" | ||
| "crypto/tls" | ||
| "encoding/json" | ||
| "fmt" | ||
| "net" | ||
| "path/filepath" | ||
| "testing" | ||
| "time" | ||
|
|
||
| . "github.com/onsi/ginkgo/v2" | ||
| . "github.com/onsi/gomega" | ||
|
|
||
| admissionv1beta1 "k8s.io/api/admission/v1beta1" | ||
| apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| clientgoscheme "k8s.io/client-go/kubernetes/scheme" | ||
| ctrl "sigs.k8s.io/controller-runtime" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| "sigs.k8s.io/controller-runtime/pkg/envtest" | ||
| logf "sigs.k8s.io/controller-runtime/pkg/log" | ||
| "sigs.k8s.io/controller-runtime/pkg/log/zap" | ||
| "sigs.k8s.io/controller-runtime/pkg/metrics/server" | ||
| "sigs.k8s.io/controller-runtime/pkg/webhook" | ||
| "sigs.k8s.io/controller-runtime/pkg/webhook/admission" | ||
| "sigs.k8s.io/kustomize/api/krusty" | ||
| "sigs.k8s.io/kustomize/kyaml/filesys" | ||
|
|
||
| accuratev1 "github.com/cybozu-go/accurate/api/accurate/v1" | ||
| accuratev2 "github.com/cybozu-go/accurate/api/accurate/v2" | ||
| accuratev2alpha1 "github.com/cybozu-go/accurate/api/accurate/v2alpha1" | ||
| "github.com/cybozu-go/accurate/hooks" | ||
| "github.com/cybozu-go/accurate/pkg/indexing" | ||
| ) | ||
|
|
||
| // These tests use Ginkgo (BDD-style Go testing framework). Refer to | ||
| // http://onsi.github.io/ginkgo/ to learn more about Ginkgo. | ||
|
|
||
| var k8sClient client.Client | ||
| var testEnv *envtest.Environment | ||
| var cancelMgr context.CancelFunc | ||
|
|
||
| func TestAPIs(t *testing.T) { | ||
| RegisterFailHandler(Fail) | ||
|
|
||
| RunSpecs(t, "Webhook Suite") | ||
| } | ||
|
|
||
| var _ = BeforeSuite(func() { | ||
| logf.SetLogger(zap.New(zap.WriteTo(GinkgoWriter), zap.UseDevMode(true))) | ||
|
|
||
| ctx, cancel := context.WithCancel(context.TODO()) | ||
| cancelMgr = cancel | ||
|
|
||
| scheme := runtime.NewScheme() | ||
| err := accuratev1.AddToScheme(scheme) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| err = accuratev2alpha1.AddToScheme(scheme) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| err = accuratev2.AddToScheme(scheme) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| err = clientgoscheme.AddToScheme(scheme) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| err = admissionv1beta1.AddToScheme(scheme) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| //+kubebuilder:scaffold:scheme | ||
|
|
||
| By("bootstrapping test environment") | ||
| testEnv = &envtest.Environment{ | ||
| Scheme: scheme, | ||
| CRDs: loadCRDs(), | ||
| WebhookInstallOptions: envtest.WebhookInstallOptions{ | ||
| Paths: []string{filepath.Join("..", "..", "config", "webhook")}, | ||
| }, | ||
| } | ||
|
|
||
| cfg, err := testEnv.Start() | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(cfg).NotTo(BeNil()) | ||
|
|
||
| k8sClient, err = client.New(cfg, client.Options{Scheme: scheme}) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(k8sClient).NotTo(BeNil()) | ||
|
|
||
| webhookInstallOptions := &testEnv.WebhookInstallOptions | ||
| mgr, err := ctrl.NewManager(cfg, ctrl.Options{ | ||
| Scheme: scheme, | ||
| WebhookServer: webhook.NewServer(webhook.Options{ | ||
| Host: webhookInstallOptions.LocalServingHost, | ||
| Port: webhookInstallOptions.LocalServingPort, | ||
| CertDir: webhookInstallOptions.LocalServingCertDir, | ||
| }), | ||
| LeaderElection: false, | ||
| Metrics: server.Options{BindAddress: "0"}, | ||
| }) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| err = indexing.SetupIndexForNamespace(ctx, mgr) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| dec := admission.NewDecoder(scheme) | ||
| hooks.SetupNamespaceWebhook(mgr, dec, true) | ||
|
|
||
| Expect(err).NotTo(HaveOccurred()) | ||
| err = hooks.SetupSubNamespaceWebhook(mgr, dec, nil, true) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| go func() { | ||
| err = mgr.Start(ctx) | ||
| if err != nil { | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| } | ||
| }() | ||
|
|
||
| // wait for the webhook server to get ready | ||
| dialer := &net.Dialer{Timeout: time.Second} | ||
| addrPort := fmt.Sprintf("%s:%d", webhookInstallOptions.LocalServingHost, webhookInstallOptions.LocalServingPort) | ||
| Eventually(func() error { | ||
| conn, err := tls.DialWithDialer(dialer, "tcp", addrPort, &tls.Config{InsecureSkipVerify: true}) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| conn.Close() | ||
| return nil | ||
| }).Should(Succeed()) | ||
|
|
||
| }) | ||
|
|
||
| var _ = AfterSuite(func() { | ||
| cancelMgr() | ||
| time.Sleep(50 * time.Millisecond) | ||
| By("tearing down the test environment") | ||
| err := testEnv.Stop() | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| }) | ||
|
|
||
| func loadCRDs() []*apiextensionsv1.CustomResourceDefinition { | ||
| kOpts := krusty.MakeDefaultOptions() | ||
| k := krusty.MakeKustomizer(kOpts) | ||
| m, err := k.Run(filesys.FileSystemOrOnDisk{}, filepath.Join("..", "..", "config", "crd")) | ||
| Expect(err).To(Succeed()) | ||
| resources := m.Resources() | ||
|
|
||
| crds := make([]*apiextensionsv1.CustomResourceDefinition, len(resources)) | ||
| for i := range resources { | ||
| bytes, err := resources[i].MarshalJSON() | ||
| Expect(err).To(Succeed()) | ||
|
|
||
| crd := &apiextensionsv1.CustomResourceDefinition{} | ||
| err = json.Unmarshal(bytes, crd) | ||
| Expect(err).To(Succeed()) | ||
|
|
||
| crds[i] = crd | ||
| } | ||
|
|
||
| return crds | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.