forked from rook/kubectl-rook-ceph
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Flatten an RBD image corrensponding to the target PVC - Remove the corresponding temporary RBD image Closes: rook#222 Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
- Loading branch information
1 parent
8a410df
commit 50fa7c6
Showing
2 changed files
with
96 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
/* | ||
Copyright 2024 The Rook Authors. All rights reserved. | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package command | ||
|
||
import ( | ||
"encoding/json" | ||
"fmt" | ||
|
||
"github.com/rook/kubectl-rook-ceph/pkg/exec" | ||
"github.com/rook/kubectl-rook-ceph/pkg/logging" | ||
"github.com/spf13/cobra" | ||
corev1 "k8s.io/api/core/v1" | ||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
) | ||
|
||
type TrashLsOutput struct { | ||
ID string `json:"id"` | ||
Name string `json:"name"` | ||
} | ||
|
||
var namespace string | ||
var allowInUse bool | ||
|
||
// FlattenRBDPVCCmd represents the rook commands | ||
var FlattenRBDPVCCmd = &cobra.Command{ | ||
Use: "flatten-rbd-pvc", | ||
Short: "Flatten the RBD image corresponding to the target RBD PVC", | ||
Args: cobra.ExactArgs(1), | ||
Run: func(cmd *cobra.Command, args []string) { | ||
pvcName := args[0] | ||
pvc, err := clientSets.Kube.CoreV1().PersistentVolumeClaims(namespace).Get(cmd.Context(), pvcName, metav1.GetOptions{}) | ||
if err != nil { | ||
logging.Fatal(err, "failed to get pvc %s/%s", namespace, pvcName) | ||
} | ||
if pvc.DeletionTimestamp != nil { | ||
logging.Fatal(fmt.Errorf("pvc %s is deleting", pvcName)) | ||
} | ||
if pvc.Status.Phase != corev1.ClaimBound { | ||
logging.Fatal(fmt.Errorf("pvc %s is not bound", pvcName)) | ||
} | ||
pvName := pvc.Spec.VolumeName | ||
pv, err := clientSets.Kube.CoreV1().PersistentVolumes().Get(cmd.Context(), pvName, metav1.GetOptions{}) | ||
if err != nil { | ||
logging.Fatal(fmt.Errorf("failed to get pv %s", pvName)) | ||
} | ||
imageName, ok := pv.Spec.CSI.VolumeAttributes["imageName"] | ||
if !ok { | ||
logging.Fatal(fmt.Errorf("pv %s would not be a CSI PVC", pvName)) | ||
} | ||
poolName, ok := pv.Spec.CSI.VolumeAttributes["pool"] | ||
logging.Fatal(fmt.Errorf("pv %s would not be a CSI PVC", pvName)) | ||
|
||
tempImageName := imageName + "-temp" | ||
if !allowInUse { | ||
// TODO: check whether the target PVC is mounted | ||
logging.Fatal(fmt.Errorf("can't flatten in-use pvc %s", pvcName)) | ||
} | ||
logging.Info("removing the temporary RBD image %s/%s if exist", poolName, tempImageName) | ||
exec.RunCommandInOperatorPod(cmd.Context(), clientSets, "rbd", []string{"-p", poolName, "trash", "mv", tempImageName}, cephClusterNamespace, operatorNamespace, false, false) | ||
out := exec.RunCommandInOperatorPod(cmd.Context(), clientSets, "rbd", []string{"-p", poolName, "trash", "ls", "--format=json"}, cephClusterNamespace, operatorNamespace, true, false) | ||
var data []TrashLsOutput | ||
json.Unmarshal([]byte(out), &data) | ||
var id string | ||
for _, d := range data { | ||
if d.Name == tempImageName { | ||
id = d.ID | ||
break | ||
} | ||
} | ||
if id != "" { | ||
exec.RunCommandInOperatorPod(cmd.Context(), clientSets, "ceph", []string{"rbd", "task", "add", "trash", "remove", fmt.Sprintf("%s/%s", poolName, id)}, cephClusterNamespace, operatorNamespace, false, false) | ||
} | ||
logging.Info("flattening the target RBD image %s/%s", poolName, imageName) | ||
exec.RunCommandInOperatorPod(cmd.Context(), clientSets, "rbd", []string{"-p", poolName, "flatten", imageName}, cephClusterNamespace, operatorNamespace, false, false) | ||
}, | ||
} | ||
|
||
func init() { | ||
FlattenRBDPVCCmd.Flags().StringVarP(&namespace, "namespace", "n", "default", "pvc's namespace") | ||
FlattenRBDPVCCmd.Flags().BoolVarP(&allowInUse, "allow-in-use", "a", false, "allow to flatten in-use image") | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters