Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified writing style of rule files #109

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Unified writing style of rule files #109

merged 2 commits into from
Jun 10, 2024

Conversation

masa213f
Copy link
Contributor

@masa213f masa213f commented Jun 10, 2024

This PR unified the writing style of the rule files. There are no functional changes.

  • Converted newline code from CRLF to LF in dell_redfish_1.17.0.yaml
  • Changed the fields' order same as old files.
  • Sorted metrics settings.
    • I checked the order by the following command.
    • $ for f in $(find ./redfish/rules -type f); do echo $f; diff -u <(grep Path: $f) <(grep Path: $f| sort); done
  • Added blank lines to metrics settings.

@masa213f masa213f self-assigned this Jun 10, 2024
- /Assembly#/
- /redfish/v1/Chassis/$
Root: /redfish/v1
Traverse:
Copy link
Contributor Author

@masa213f masa213f Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I converted the line feed code from CRLF to LF in this file.
Please Hide whitespace when reviewing.

@masa213f masa213f marked this pull request as ready for review June 10, 2024 07:12
@masa213f masa213f requested a review from morimoto-cybozu June 10, 2024 07:12
@morimoto-cybozu
Copy link
Contributor

@masa213f
Please describe your intention in the commit message first as well as the pull request comment.
Most developers will track the commits rather than the pull requests to investigate the history.

masa213f added 2 commits June 10, 2024 17:44
Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
- Changed the fields' order same as old files.
- Sorted metrics settings.
- Added blank lines to metrics settings.

Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
@masa213f masa213f changed the title Fix existing rules Unified writing style of rule files Jun 10, 2024
@masa213f
Copy link
Contributor Author

@morimoto-cybozu
Thanks for the good comment. I fixed.
In addition, I have been sorting some metrics settings.

@masa213f masa213f merged commit 4664290 into main Jun 10, 2024
1 check passed
@masa213f masa213f deleted the update-20240610 branch June 10, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants