Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update prettier and eslint-config-prettier #687

Merged
merged 1 commit into from
Jul 19, 2023
Merged

chore: update prettier and eslint-config-prettier #687

merged 1 commit into from
Jul 19, 2023

Conversation

nissy-dev
Copy link
Contributor

@nissy-dev nissy-dev commented Jul 19, 2023 •
edited
Loading

I updated prettier and eslint-config-prettier (major) because #680 isn't merged due to failing CI.

koba04
koba04 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍 LGTM!!!

@koba04
Copy link
Contributor

koba04 commented Jul 19, 2023

@nissy-dev
eslint-plugin-prettier has prettier": ">=3.0.0 as its peerDeps.
Should we drop Prettier v2 support as well?
https://github.com/prettier/eslint-plugin-prettier/blob/b2b93c30c5679d38a094589eb608d0f5d7615aaf/package.json#L41

If so, this should be a breaking change.

@nissy-dev
Copy link
Contributor Author

@koba04

Should we drop Prettier v2 support as well?
If so, this should be a breaking change.

Yes. I also think this PR leads to a breaking changes

@koba04 koba04 merged commit de15262 into cybozu:master Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koba04 koba04 koba04 approved these changes

@sosukesuzuki sosukesuzuki Awaiting requested review from sosukesuzuki sosukesuzuki is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nissy-dev @koba04